-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
TST: add test for dtype
argument in str.decode
#61872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 16, 2025
pandas/tests/strings/test_strings.py
Outdated
def test_decode_with_dtype_none(): | ||
# Ensure that future.infer_string is enabled | ||
set_option("future.infer_string", True) | ||
ser = Series([b"a", b"b", b"c"]) # Use byte strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ser = Series([b"a", b"b", b"c"]) # Use byte strings | |
ser = Series([b"a", b"b", b"c"]) |
mroeschke
reviewed
Jul 16, 2025
pandas/tests/strings/test_strings.py
Outdated
|
||
def test_decode_with_dtype_none(): | ||
# Ensure that future.infer_string is enabled | ||
set_option("future.infer_string", True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the option_context
context manager
mroeschke
reviewed
Jul 17, 2025
mroeschke
reviewed
Jul 17, 2025
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Jul 28, 2025
Thanks @hippowm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case for
str.decode
and ensures it correctly infers the string datatype, whendtype=None
and the optionfuture.infer_string
is used. This argument was introduced in PR #60940 but has no test for None. This test adds coverage to the following line:Note: Parts of this test have been automatically generated by a novel technique that we're currently developing as part of an academic research project aiming at improving test coverage. To not waste developer time, two researchers manually checked the test before submitting it. We appreciate the developers' time and any feedback is welcomed.